feat(bmj): show elapsed time for already-completed benchmark jobs in bmj watch#177
Open
rlagentflowbeta[bot] wants to merge 1 commit intomainfrom
Open
feat(bmj): show elapsed time for already-completed benchmark jobs in bmj watch#177rlagentflowbeta[bot] wants to merge 1 commit intomainfrom
rlagentflowbeta[bot] wants to merge 1 commit intomainfrom
Conversation
…watch When `rli bmj watch` is called on a job that has already completed, it now displays the total elapsed time by inferring the end time from the benchmark run data (start_time_ms + duration_ms). Previously, the completed-job path printed the results table without any timing info.
Contributor
Author
|
🤖 This PR was created by Agent Flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How it works
`BenchmarkJobView` has `create_time_ms` (start) but no end time field. `BenchmarkRunView` has both `start_time_ms` and `duration_ms`, so `end_time = start_time_ms + duration_ms`. The job is considered complete when the last benchmark run finishes, so total elapsed = `max(run end times) - job.create_time_ms`.
Note: the `BenchmarkJobView` API has no update endpoint and no metadata field, so caching the computed end time server-side is not currently feasible.
Test plan
🤖 Generated with Claude Code